Post-merge-review: Fix template-no-invalid-link-title: track @ember/routing LinkTo import#2674
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 13, 2026
Conversation
…t in GJS/GTS The rule flagged <LinkTo> in all files, but in GJS/GTS strict mode LinkTo only refers to Ember's router link when explicitly imported from '@ember/routing'. A user-authored component named LinkTo would be incorrectly flagged. Adds ImportDeclaration tracking matching the pattern already used in template-no-invalid-link-text.
| if (!isStrictMode) { | ||
| return; | ||
| } | ||
| if (node.source.value === '@ember/routing') { |
Contributor
There was a problem hiding this comment.
we could probably extract all this logic to a helper, too since it's seeming pretty common
NullVoxPopuli
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterFlags
<LinkTo>in all files. In GJS/GTS strict mode,LinkToonly refers to Ember's router link when explicitly imported from@ember/routing. A user-authored component namedLinkTois falsely flagged.Fix
Track
ImportDeclarationfrom@ember/routing, matching the pattern intemplate-no-invalid-link-text.Test plan
47/47 tests pass. 1 new GJS valid test (unimported
<LinkTo>) fails on master.Co-written by Claude.